CLOUDSTACK-10212: Update Netmask/Gateway when Changing IPv4 address#2388
CLOUDSTACK-10212: Update Netmask/Gateway when Changing IPv4 address#2388yadvr merged 1 commit intoapache:masterfrom
Conversation
|
@blueorangutan package |
|
@wido can you check unit test/build failures from travis: |
This can otherwise cause problems in Basic Networking where multiple IPv4 ranges are configured in a POD. Signed-off-by: Wido den Hollander <wido@widodh.nl>
|
Fixed @rhtyd ! Tests are now all passing. |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1618 |
|
@rhtyd I thought I added the milestone 4.11 to this PR, but I see you removed it: wido added this to the 4.11 milestone 3 days ago rhtyd removed this from the 4.11 milestone 2 days ago Was this due to the NPE during the tests? As this is a bug, we can include it in 4.11, right? |
|
@wido Yes, due to NPE in tests I could run further tests/reviews. I've removed PRs from 4.11 milestone where authors were not replying or were busy elsewhere. This was done in past 3 days, as today was the "freeze" date. I'll re-include this on your request but now no more PRs please :) @blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Ok, get it @rhtyd :) It was the weekend in between which made me not reply to the PR. I don't have anything else to submit :) |
|
Trillian test result (tid-2076)
|
|
Tests LGTM, the one failure is env related. |
This can otherwise cause problems in Basic Networking where multiple
IPv4 ranges are configured in a POD.
Signed-off-by: Wido den Hollander wido@widodh.nl